Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scene accessibility when only later scenes are inaccessible #1897

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Wcarr112
Copy link
Contributor

@Wcarr112 Wcarr112 commented Jan 3, 2025

There was a bug with this for loop where the order of the video files impacted the final state of the video's accessibility flag. Proper logic should be marking a scene as accessible if any video exists.

Repro

  • Have 1 scraped scene
  • Download 2 video files for it
  • Have 1 video file be mounted and accessible and another not be mounted

When the for loop runs, if the non-accessible video file appears later in the files list, it will mark the scene as not accessible even though another video file exists.

@crwxaj crwxaj merged commit 6e8d8bd into xbapps:master Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants