Implement Heresphere needsMediaSource flag #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to implement the needsMediaSource flag in the Heresphere request body.
Heresphere sets this flag if it needs media source details, i.e. which is only when it wants to play the media. The advantage of checking the flag is for trailers, some of which may require a scene page to be scraped to get the current trailer URL (i.e. to get the latest tokens, expiry times, etc). When Heresphere is started it will request a library list and then each scene in the list, triggering a scrape for those trailers. These requests have needsMediaSource set to false as Heresphere is not playing the video and only needs the other metadata, e.g. title, actors, tags, etc.
This is just a minor performance change, reducing or spreading the scrapes required by Trailers until the Trailer is requested to be played.