Split of "get" config for list and show actions#42
Open
andesk wants to merge 6 commits into
Open
Conversation
It seems that in the last pull request this variable name issue was introduced...
…list, bc breaks should be preserved
…list, bc breaks should be preserved
Author
There was a problem hiding this comment.
Maybe it is not the best solution working like this, but it reduces code duplication a lot...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we needed a different output of attributes depending on list/show action we introduced a more or less backwards compatible approach to provide this in the plugin. See adjusted README file.
Do be able to have different logic in the action we introduced several copied methods generated for both get actions. For example instead of function query() we have now a queryList() and a queryShow(). So this somehow breaks bc if a developer would have overwritten the query() method in the actions class. The configuration itself "inherits" and is only used if a more concrete configuration is set for get_list or get_show.
What do you think about that improvement?
Motivation is e.g. to reduce query complexity for list by not embedding any relations and doing this only in show).