Refactoring and code cleanup#31
Open
nederdirk wants to merge 17 commits into
Open
Conversation
added 15 commits
January 30, 2014 17:09
factor out validateIndex factor out validateShow factor out validateUpdate factor out updateObjectFromRequest factor out queryFetchOne factor out postValidate factor out update(Post)Validators factor out doSave factor out CreateObject factor out createAction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code generator generated a lot of duplicate code, I made an effort to clean some of these duplications.
Some things that have been done:
sfDoctrineRestGeneratorActionsbase class, holding common functionsadditional_paramsvariable to the object scope (thus initializing the array only once in each request)sfValidatorErrors when validations fail (technically not refactoring, but the semantics of the code stay the same)