We should override the doctrine query and keeps the sort and limit features#16
Open
mteneur wants to merge 5 commits into
Open
We should override the doctrine query and keeps the sort and limit features#16mteneur wants to merge 5 commits into
mteneur wants to merge 5 commits into
Conversation
added 5 commits
March 23, 2012 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query generation with limit and sort is in one method.
Could be nice to override the query build method in generated module, and let the generator to add sort and limits to the query automatically (i.e with generator.yml file) .