Major improvements all over the place!#13
Open
damienalexandre wants to merge 11 commits into
Open
Conversation
… XML one, and work on XML collections for the XML serializer
…array on the whole process.
…the query method used also in update and delete...
… undocumented actions_base_class param (usefull to me)
Owner
|
Could you please propose separate atomical pull requests for all these improvements? Thank you |
|
and do not forget to rebase, you have conflicts. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some work to contribute on the plugin:
camelizeoptionroot_nameoptionplural_root_nameoptionBUT we still need to do some stuff before a 1.0 release imho:
The main issue will be merging my Xml Serializer changes with the ones done in 4ba92e2, unit test can help.
I know symfony standard is lime (and that's why the generated functional test are lime one's) but as plugin developper we can use PhpUnit (which is way more efficient and dev friendly).
What do you think about that?
I could work on some test but I'm asking; lime or phpunit?
Have fun merging those stuffs ;-) Cheer.