lvutil: Ensure we can detach when deflate call is not possible #649
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue found in our Linstor Driver that also applies to this one AFAWCU. |
benjamreis
force-pushed
the
lvhd-detach-not-raise
branch
from
a443269 to
9f34882
Compare
benjamreis
changed the title
MarkSymsCtx
reviewed
Nov 29, 2023
drivers/lvhdutil.py
Outdated
| try: | ||
| detachThinImpl(session, lvmCache, srUuid, vdiUuid) | ||
| except Exception as e: | ||
| util.SMlog('Failed to detach properly VDI {}: {}'.format(vdiUuid, e)) |
There was a problem hiding this comment.
It is preferred to use f-string for new things now that the code is python3
Raising during detach call can leak a tapdisk process that will cause trouble later. Signed-off-by: BenjiReis <[email protected]>
benjamreis
force-pushed
the
lvhd-detach-not-raise
branch
from
9f34882 to
f3c4bfd
Compare
MarkSymsCtx
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising during detach call can leak a tapdisk process that will cause trouble later.