Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Add more filters to List group milestones #1998

Conversation

adamcohen2
Copy link
Contributor

This MR adds the following filters to the List group milestones endpoint:

  • SearchTitle
  • IncludeAncestors
  • IncludeDescendents
  • UpdatedBefore
  • UpdatedAfter
  • ContainingDate
  • StartDate
  • EndDate

See Document fields for List Group milestones API for more details.

@adamcohen2 adamcohen2 changed the title Add more filters to group milestones Add more filters to List group milestones Aug 26, 2024
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added*time.Time fields should be *ISOTime fields (using the ISO 8601 format) instead. If you can update that, this PR is good to go...

@adamcohen2
Copy link
Contributor Author

The newly added*time.Time fields should be *ISOTime fields (using the ISO 8601 format) instead. If you can update that, this PR is good to go...

@svanharmelen done, thanks for the quick review!

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamcohen2 👍🏻

@svanharmelen svanharmelen merged commit 2269380 into xanzy:main Aug 26, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants