Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Add expires_at for token rotation operations #1841

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

buehlmann
Copy link
Contributor

@buehlmann buehlmann commented Dec 1, 2023

Add options with expires_at attribute for all token rotation functions and implemented tests for those:

  • Rotate personal access tokens
  • Rotate project access tokens
  • Rotate group access tokens

The expires_at attribute was Introduced in GitLab 16.6.

As the rotate* functions did not accept options so far, this is a breaking-change for these three functions.

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @buehlmann 👍🏻

@svanharmelen svanharmelen merged commit bc91377 into xanzy:main Dec 9, 2023
3 checks passed
@buehlmann
Copy link
Contributor Author

@svanharmelen thanks for merging 🤘

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants