Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Commit

Permalink
Rename GroupId to GroupID in the MemberRole and Iteration structs
Browse files Browse the repository at this point in the history
Following the Go
[guidelines](https://go.dev/wiki/CodeReviewComments#initialisms) on
initialism
  • Loading branch information
svanharmelen committed Aug 26, 2024
1 parent 2269380 commit f97a106
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion group_members_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ func TestGetGroupMemberCustomRole(t *testing.T) {
AccessLevel: AccessLevelValue(30),
MemberRole: &MemberRole{
ID: 1,
GroupId: 2,
GroupID: 2,
Name: "TestingCustomRole",
Description: "",
BaseAccessLevel: AccessLevelValue(30),
Expand Down
2 changes: 1 addition & 1 deletion member_roles.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type MemberRole struct {
ID int `json:"id"`
Name string `json:"name"`
Description string `json:"description,omitempty"`
GroupId int `json:"group_id"`
GroupID int `json:"group_id"`
BaseAccessLevel AccessLevelValue `json:"base_access_level"`
AdminCICDVariables bool `json:"admin_cicd_variables,omitempty"`
AdminComplianceFramework bool `json:"admin_compliance_framework,omitempty"`
Expand Down
6 changes: 3 additions & 3 deletions member_roles_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ func TestListMemberRoles(t *testing.T) {
ID: 1,
Name: "GuestCodeReader",
Description: "A Guest user that can read code",
GroupId: 1,
GroupID: 1,
BaseAccessLevel: 10, // Guest Base Level
ReadCode: true,
},
{
ID: 2,
Name: "GuestVulnerabilityReader",
Description: "A Guest user that can read vulnerabilities",
GroupId: 1,
GroupID: 1,
BaseAccessLevel: 10, // Guest Base Level
ReadVulnerability: true,
},
Expand Down Expand Up @@ -84,7 +84,7 @@ func TestCreateMemberRole(t *testing.T) {
Name: "Custom guest",
Description: "a sample custom role",
BaseAccessLevel: GuestPermissions,
GroupId: 84,
GroupID: 84,
AdminCICDVariables: false,
AdminComplianceFramework: false,
AdminGroupMembers: false,
Expand Down
2 changes: 1 addition & 1 deletion resource_iteration_events.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Iteration struct {
ID int `json:"id"`
IID int `json:"iid"`
Sequence int `json:"sequence"`
GroupId int `json:"group_id"`
GroupID int `json:"group_id"`
Title string `json:"title"`
Description string `json:"description"`
State int `json:"state"`
Expand Down
4 changes: 2 additions & 2 deletions resource_iteration_events_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func TestListIssueIterationEventsService_ListIssueIterationEvents(t *testing.T)
ID: 133,
IID: 1,
Sequence: 1,
GroupId: 153,
GroupID: 153,
Title: "Iteration 1",
Description: "Lorem ipsum dolor sit amet, consectetur adipiscing elit.",
State: 1,
Expand Down Expand Up @@ -167,7 +167,7 @@ func TestListIssueIterationEventsService_GetIssueIterationEvent(t *testing.T) {
ID: 133,
IID: 1,
Sequence: 1,
GroupId: 153,
GroupID: 153,
Title: "Iteration 1",
Description: "Lorem ipsum dolor sit amet, consectetur adipiscing elit.",
State: 1,
Expand Down

0 comments on commit f97a106

Please sign in to comment.