-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Update run.py #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update run.py #261
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,59 +13,66 @@ | |
# limitations under the License. | ||
|
||
import logging | ||
|
||
from model import LanguageModelConfig, TransformerConfig, QuantizedWeight8bit as QW8Bit | ||
from runners import InferenceRunner, ModelRunner, sample_from_model | ||
|
||
|
||
# Path to the checkpoint directory | ||
CKPT_PATH = "./checkpoints/" | ||
|
||
|
||
def main(): | ||
# Initialize model configuration | ||
grok_1_model = LanguageModelConfig( | ||
vocab_size=128 * 1024, | ||
vocab_size=128 * 1024, # 128K vocabulary size | ||
pad_token=0, | ||
eos_token=2, | ||
sequence_len=8192, | ||
sequence_len=8192, # Sequence length | ||
embedding_init_scale=1.0, | ||
output_multiplier_scale=0.5773502691896257, | ||
embedding_multiplier_scale=78.38367176906169, | ||
model=TransformerConfig( | ||
emb_size=48 * 128, | ||
emb_size=48 * 128, # Embedding size | ||
widening_factor=8, | ||
key_size=128, | ||
num_q_heads=48, | ||
num_kv_heads=8, | ||
num_layers=64, | ||
num_q_heads=48, # Query heads | ||
num_kv_heads=8, # Key/Value heads | ||
num_layers=64, # Number of layers | ||
attn_output_multiplier=0.08838834764831845, | ||
shard_activations=True, | ||
# MoE. | ||
num_experts=8, | ||
num_selected_experts=2, | ||
# Activation sharding. | ||
num_experts=8, # Mixture of Experts (MoE) | ||
num_selected_experts=2, # Selected experts for MoE | ||
data_axis="data", | ||
model_axis="model", | ||
), | ||
) | ||
inference_runner = InferenceRunner( | ||
pad_sizes=(1024,), | ||
runner=ModelRunner( | ||
model=grok_1_model, | ||
bs_per_device=0.125, | ||
checkpoint_path=CKPT_PATH, | ||
), | ||
name="local", | ||
load=CKPT_PATH, | ||
tokenizer_path="./tokenizer.model", | ||
local_mesh_config=(1, 8), | ||
between_hosts_config=(1, 1), | ||
) | ||
inference_runner.initialize() | ||
gen = inference_runner.run() | ||
|
||
inp = "The answer to life the universe and everything is of course" | ||
print(f"Output for prompt: {inp}", sample_from_model(gen, inp, max_len=100, temperature=0.01)) | ||
try: | ||
# Initialize the inference runner with the model and configurations | ||
inference_runner = InferenceRunner( | ||
pad_sizes=(1024,), | ||
runner=ModelRunner( | ||
model=grok_1_model, | ||
bs_per_device=0.125, # Batch size per device | ||
checkpoint_path=CKPT_PATH, | ||
), | ||
name="local", | ||
load=CKPT_PATH, | ||
tokenizer_path="./tokenizer.model", | ||
local_mesh_config=(1, 8), # Configuration for the local execution mesh | ||
between_hosts_config=(1, 1), # Configuration for between-host execution | ||
) | ||
inference_runner.initialize() | ||
except Exception as e: | ||
logging.error(f"Failed to initialize the inference runner: {e}") | ||
return | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should raise the exception as an error will cause the |
||
|
||
try: | ||
gen = inference_runner.run() | ||
|
||
inp = "The answer to life the universe and everything is of course" | ||
output = sample_from_model(gen, inp, max_len=100, temperature=0.01) | ||
print(f"Output for prompt: '{inp}':\n{output}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original code does not place the output on a new line. Can you be sure this won't change behavior for clients utilizing this output for something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you tested the code? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Irrelevant. You changed behavior without test coverage. |
||
except Exception as e: | ||
logging.error(f"Failed during model inference: {e}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should also raise |
||
|
||
if __name__ == "__main__": | ||
logging.basicConfig(level=logging.INFO) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add a comment that repeats the parameter name? Is there genuine concern that "sequence_len" isn't already clear?