Fix SNI handling with proxies in requests library #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue psf#6900, which involves the inability to request a private URL endpoint with custom SNI and self-signed CA when a proxy is set. The changes made ensure that the
server_hostname
is correctly set based on theHost
header in the request, even when using a proxy.Changes Made:
get_connection_with_tls_context
method inadapters.py
to extract theHost
header and use it for SNI.test_adapters.py
to verify that theserver_hostname
is correctly passed in various scenarios, including when a proxy is used.Expected Outcome:
With these changes, users should be able to successfully make requests to private URL endpoints with custom SNI and self-signed CA, regardless of whether a proxy is used.
Original Task: swe-requests/m99px2ucjsk6
Author: Pandelis Zembashis