#6609 Lyric Track Unable to move - Fix

[AGFazio]

Lyric/Timing Track Drag Broken Since PR #6479

What broke

PR #6479 (ghost drag-to-move) inserted a new code path in mouseDown() that intercepts all EFFECT_RESIZE_MOVE clicks — including clicks on timing track items (words, phrases, phonemes). It builds a list of selected effects to drag (mEffectMoveSnapshots), but explicitly skips
timing rows when doing so (line 2226). The result: timing effects always produce an empty snapshot list, UpdateEffectMoveDragState() returns immediately, and dragging a lyric item does nothing.

How timing drag worked before

Before PR #6479, clicking a timing effect's center with EFFECT_RESIZE_MOVE fell into the mResizing = true branch → Resize() → ResizeMoveMultipleEffectsMS() → MoveAllSelectedEffects(). That chain handles timing effects correctly and skips re-rendering (timing tracks don't need
it).

The fix

Two lines added in EffectsGrid.cpp at the top of the drag-dispatch block:

Row_Information_Struct* anchorRI = mSequenceElements->GetVisibleRowInformation(row);
bool isTimingDrag = (anchorRI != nullptr && anchorRI->element->GetType() == ElementType::ELEMENT_TYPE_TIMING);
if (!isTimingDrag && mResizingMode == EFFECT_RESIZE_MOVE && selectedEffect != nullptr) {
// Ghost drag path — model effects only

When the clicked row is a timing element, isTimingDrag = true gates out the ghost drag block. The code falls through to the existing else if (mResizingMode != EFFECT_RESIZE_NO) branch, sets mResizing = true, and restores the pre-#6479 drag behavior for timing tracks. Model effect
drag (the ghost drag feature) is completely unchanged.

[Copilot]

Pull request overview

Fixes a regression in the wxWidgets sequencer grid where timing/lyric items could no longer be dragged to move after the ghost drag-to-move path was introduced (PR #6479). The change ensures timing-row drags continue to use the pre-#6479 resize/move path, while keeping ghost drag behavior limited to model-effect rows.

Changes:

• Detects when the mouse-down occurs on a timing element row and prevents entering the ghost drag-to-move code path for that case.
• Restores the legacy “move via resize/move handling” path for timing/lyric drags without altering model-effect ghost drag behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.