Ignore empty effectpreset files#6566
Open
cybercop23 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates effect preset JSON/backup handling to avoid creating or prompting about empty preset files, and documents the behavior change in the release notes.
Changes:
- Skip “newer backup” prompts by deleting empty backup preset files on load.
- Avoid writing empty effect preset JSON files; delete existing preset JSON when there are no presets.
- Update release notes describing the new behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src-ui-wx/app-shell/TabSequence.cpp | Adds logic to skip empty preset JSON/backup creation and cleanup empty/stale backup files. |
| README.txt | Adds a release note entry describing the preset JSON/backup behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Lets remove the code about deleting a file .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the move to the JSON file, if a backup file exists and it is empty, you get prompted about a newer file.
Ignore if file is empty, ie: no presets. Also, don't save the file if there are no presets to be saved.