Vendor catalog search: Search button, native selection highlight

[heffneil]

Summary

• Vendor catalog dialog: add a visible Search button to the right of the search field; the in-field magnifier icon was easy to miss, especially on macOS. Bind wxEVT_TEXT_ENTER so pressing Enter also advances to the next match.
• Vendor catalog dialog: when Search finds a match, make that item the active selection (instead of just bold text) and call SetFocus() on the tree so it renders with the system focused-selection colours (blue+white) rather than the muted unfocused colours. Successive Search presses remove the prior find from the selection so matches don't pile up; manual Ctrl+click selections survive.
• Vendor catalog dialog: reconcile VendorModelDialog.wxs with the cpp guards — the .wxs had been left out of sync after Fix vendor model search on Windows (#6252) #6267 swapped TextCtrl_Search to a wxSearchCtrl.

(The layout-panel filter auto-clear is split out into #6271.)

Test plan

• Open Import → Download Models, type a search term — Search button visible to right of the field
• Press Search (or Enter, or the in-field magnifier) — found item is the active selection, scrolled into view, blue+white styling
• Press Search again — previous highlight cleared, next match becomes the selection
• Ctrl+click extra items in tree — manual selections preserved across Search presses
• Cancel (X) — clears highlight

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Updates the vendor catalog “Import → Download Models” search UI/behavior by making the search action more discoverable and adding clearer visual indication of the current match, while bringing the wxSmith .wxs back in sync with the generated C++ dialog code.

Changes:

• Replaces the search field with a wxSearchCtrl and wires its search/cancel buttons to existing handlers.
• Adds a visible “Next” button next to the search field to advance through matches.
• Highlights the current match with a yellow background (and clears it on text change/cancel/manual selection).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src-ui-wx/wxsmith/VendorModelDialog.wxs	Updates wxSmith layout: wxSearchCtrl + event handlers, and changes search button label to “Next”.
src-ui-wx/import_export/VendorModelDialog.h	Adds missing Button_Search member and ID_BUTTON4 identifier to match the dialog layout.
src-ui-wx/import_export/VendorModelDialog.cpp	Implements the new button/sizer layout, binds search/cancel events, and applies/clears background highlight on matched items.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[heffneil]

@derwin12 can you double check the windows. I ran it in a VM and it works as I expect but this one has been finicky along with the other one I just can't get that other one operational in windows

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src-ui-wx/import_export/VendorModelDialog.cpp:1482

• During the selection-restore loop in OnButton_SearchClick, multiple SelectItem/UnselectItem calls fire wxEVT_TREE_SEL_CHANGED events. Even with the _searchInProgress guard, this handler still calls UpdatePanelForItem() for each intermediate selection change, which can cause unnecessary UI work/flicker and potentially leave the details panel briefly showing the wrong item. Since OnButton_SearchClick explicitly calls UpdatePanelForItem(current) at the end, consider skipping UpdatePanelForItem entirely while _searchInProgress is true.

void VendorModelDialog::OnTreeCtrl_NavigatorSelectionChanged(wxTreeEvent& event)
{
    wxTreeItemId startid = event.GetItem();
    if (!startid.IsOk()) {
        startid = GetFocusedItem();
    }
    // User manually selected a different item — clear the search bold/cursor.
    // The _searchInProgress guard prevents the re-add loop in OnButton_SearchClick
    // (which fires SEL_CHANGED for each prior selection it restores) from clearing
    // _lastSearchItem we just set.
    if (!_searchInProgress && _lastSearchItem.IsOk() && startid != _lastSearchItem) {
        TreeCtrl_Navigator->SetItemBold(_lastSearchItem, false);
        _lastSearchItem = wxTreeItemId();
    }
    UpdatePanelForItem(startid);
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[heffneil]

Addressed the Copilot thread in 5a4a119. Went with the "keep the native-selection highlight, just clean up properly" approach (Option A) rather than reverting to bold-only:

• Added TreeCtrl_Navigator->UnselectItem(_lastSearchItem) alongside the existing SetItemBold(false) in all three clear paths: OnTextCtrl_SearchText, OnSearchCancelClick, and the selection-changed handler in OnTreeCtrl_NavigatorSelectionChanged.
• UnselectItem is a no-op if the row isn't selected, so this is harmless in the common case (plain click-elsewhere → tree natively deselected the old row already).
• The only behavioral edge: if the user explicitly Ctrl-clicked the search-highlighted row to keep it in a manual multi-select, clearing the search will now drop that one row. Recoverable in one click and avoids the much more visible "selection is stuck after clearing search" bug.

[heffneil]

Closing as superseded by #6256.

#6270 added a find-next search (jump to the next matching model in the catalog tree and highlight it). #6256 takes the better approach for browsing a large catalog: a hierarchy-aware live filter that narrows the tree to only matching vendors/categories/models as you type. With the filter, there's nothing to jump-to/highlight, so the selection-focus machinery here isn't needed.

Going with the filter (#6256) instead. Thanks!