-
Notifications
You must be signed in to change notification settings - Fork 256
Add hierarchy-aware live filter to vendor model catalog #6256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heffneil
wants to merge
33
commits into
xLightsSequencer:master
Choose a base branch
from
heffneil:experiment/vendor-catalog-filter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 28 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
e78dfc4
Add hierarchy-aware live filter to vendor model catalog
986bfe6
Address Copilot review on #6256
adb20f9
Catalog filter: collapse two boxes into one with whitespace tokens
a10a3d9
Catalog filter: hide suppressed vendors when filter is active
1144a06
Update README to reflect single-box whitespace-tokenized filter
49c270f
Address Copilot review on #6256
0e37510
RebuildTreeUI: UnselectAll before DeleteAllItems + re-entrancy guard
2f25c07
Catalog filter: avoid UI freeze on Windows under heavy filters
6191b08
RebuildTreeUI: disable tree during rebuild, RAII guard
3ec71bb
Catalog filter: drop tree Disable, expansion was suppressed
19f50d8
Hide bottom Search row; new live filter replaces it on all platforms
34f3626
AddHierachy: Expand after children populated, not before
b5342ed
Catalog filter: restore focus to filter ctrl after rebuild
07caeba
Expand multi-wiring model nodes when filter is active
9805b4a
Fix Windows filter losing typed text mid-word
835d332
Defer caret-to-end via CallAfter for Windows WM_SETFOCUS
37aaf86
Fix double-Thaw assert in RebuildTreeUI
58e6f58
Merge master and fix double-Thaw assert
fbe1873
Reset stale _lastSearchItem on filter rebuild + restore handler busy …
cfee5bf
Defer _treeRebuilding clear + hide masters bottom search
be30c8d
Guard UpdatePanelForItem with _treeRebuilding too
9eaefd6
Revert deferred flag clear, validate stale tree items instead
d8b9eec
Add spdlog tracing for filter rebuild diagnosis
0dc1499
Add per-step tracing to find rebuild hang point
97d205b
Remove per-vendor auto-Expand under filter (hangs Windows)
448867d
Filter UX: expand vendors but leave categories collapsed
b8505dc
Force Refresh+Update after rebuild for Windows paint sync
97bc228
Drop stale SEL_CHANGED events post-rebuild without GetFocusedItem fal…
947aefd
Defer Refresh+Update until after RebuildScope thaws
c1949da
Remove all auto-expand under filter to fix EFL hang on Windows
9edd3cc
Merge remote-tracking branch 'origin/master' into vendor-catalog-filt…
heffneil ef0dbb0
Vendor catalog: flat de-duplicated model list per vendor (#6256)
heffneil 53dcf41
Vendor catalog: strictly flat results + auto-expand under filter
heffneil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule macOS
updated
2 files
| +2 −1 | src-apple-core/osxUtils/xlAppleUtils.swift | |
| +1 −0 | xLights.xcodeproj/project.pbxproj |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.