Add aubio sources for stem onset detection#8
Open
o0charlie0o wants to merge 1 commit into
Open
Conversation
Adds the vendored aubio C source files (cvec, fmat, fvec, lvec, mathutils, musicutils, vecutils, onset/, spectral/, temporal/, utils/) as a new "aubio" PBXGroup under Libraries, registers them in the xLights target's Sources build phase, and adds ../dependencies/aubio/src to the header search paths for every relevant build configuration. Required by StemOnsetDialog (in src-ui-wx/), which uses aubio's spectral flux + peak picker to generate timing tracks from stem transients. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the vendored aubio C source files to the xLights Xcode project so the new Audio Stems panel (in the main repo) can use aubio's spectral-flux peak picker to generate timing tracks from stem transients.
The companion main-repo PR is xLightsSequencer/xLights#6255 — please merge this one first so the gitlink there can land on a published
maincommit.Changes
aubioPBXGroup under Libraries with the aubio C sources (cvec,fmat,fvec,lvec,mathutils,musicutils,vecutils,onset/,spectral/,temporal/,utils/).xLightstarget's Sources build phase.../dependencies/aubio/srcadded to the header search paths for every relevant build configuration.Tested on
Happy to discuss any of this.