Fix flight revoke incompatibility with other mods#41
Closed
JordanPlayz158 wants to merge 3 commits intoxGabou:mainfrom
Closed
Fix flight revoke incompatibility with other mods#41JordanPlayz158 wants to merge 3 commits intoxGabou:mainfrom
JordanPlayz158 wants to merge 3 commits intoxGabou:mainfrom
Conversation
…e same jvmargs from fabric to the root gradle.properties to allow gradle to run without erroring.
…yer to fly (so long as you don't have an identity enabled)
JordanPlayz158
deleted the
fix/flight-revoke-incompatibility-with-other-mods
branch
Author
|
Moved to #42 as one of the preconditions for merging is signed commits and there didn't seem to be a clean way to sign already pushed commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
472fb124a605f0a2e806ccea04c9afb3c8ca9622added a change that always updates the flight state each tick (regardless of identity status (whether you have one or not), this caused a conflict with other mods (such as Hex Casting which modify the flying state), this fix remedies that issue by checking whether the player is using an identity before changing and syncing flight state, because in the case of no identity, it will always return false for allowing flight.