Skip to content

chore(go/http): remove unused extractPayment/createHTTPResponse #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feldmannn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(go/http): remove unused extractPayment/createHTTPResponse #2342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions go/http/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,25 +856,6 @@ func (s *x402HTTPResourceServer) extractPaymentV2(adapter HTTPAdapter) (*types.P
return payload, nil
}

// extractPayment extracts payment from headers (legacy method, now calls extractPaymentV2)
//
//nolint:unused // Legacy method kept for API compatibility
func (s *x402HTTPResourceServer) extractPayment(adapter HTTPAdapter) *x402.PaymentPayload {
payload, err := s.extractPaymentV2(adapter)
if err != nil || payload == nil {
return nil
}

// Convert V2 to generic PaymentPayload for compatibility
return &x402.PaymentPayload{
X402Version: payload.X402Version,
Payload: payload.Payload,
Accepted: x402.PaymentRequirements{}, // TODO: Convert
Resource: nil,
Extensions: payload.Extensions,
}
}

// decodeBase64Header decodes a base64 header to JSON bytes
func decodeBase64Header(header string) ([]byte, error) {
return base64.StdEncoding.DecodeString(header)
Expand Down Expand Up @@ -933,20 +914,6 @@ func (s *x402HTTPResourceServer) createHTTPResponseV2(paymentRequired types.Paym
}, nil
}

// createHTTPResponse creates response instructions (legacy method)
//
//nolint:unused // Legacy method kept for API compatibility
func (s *x402HTTPResourceServer) createHTTPResponse(paymentRequired x402.PaymentRequired, isWebBrowser bool, paywallConfig *PaywallConfig, customHTML string) (*HTTPResponseInstructions, error) {
// Convert to V2 and call V2 method
v2Required := types.PaymentRequired{
X402Version: 2,
Error: paymentRequired.Error,
Resource: nil, // TODO: convert
Extensions: paymentRequired.Extensions,
}
return s.createHTTPResponseV2(v2Required, isWebBrowser, paywallConfig, customHTML, nil)
}

// createSettlementHeaders creates settlement response headers
func (s *x402HTTPResourceServer) createSettlementHeaders(response *x402.SettleResponse) (map[string]string, error) {
encodedHeader, err := encodePaymentResponseHeader(*response)
Expand Down
Loading