fix(core): harden token amount validation#2340
Open
FidelCoder wants to merge 1 commit into
Open
Conversation
|
@FidelCoder is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2090.
Replaces the decimal validation regex in
convertToTokenAmount()with a linear validator to avoid ReDoS-style backtracking on long invalid input.Changes
Tests
git diff --checkpnpm --filter @x402/core test -- test/unit/utils/utils.test.tsbecause local Node is v18.19.1 and pnpm requires Node v22.13+pnpm --filter @x402/core lint:checkbecause local Node is v18.19.1 and pnpm requires Node v22.13+pnpm --filter @x402/core format:checkbecause local Node is v18.19.1 and pnpm requires Node v22.13+pnpm --filter @x402/core buildbecause local Node is v18.19.1 and pnpm requires Node v22.13+