docs(evm): clarify channel id and transfer method defaults#2333
Closed
EfeDurmaz16 wants to merge 1 commit into
Closed
docs(evm): clarify channel id and transfer method defaults#2333EfeDurmaz16 wants to merge 1 commit into
EfeDurmaz16 wants to merge 1 commit into
Conversation
|
@EfeDurmaz16 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channelIddocstring to reference the EIP-712computeChannelIdderivation instead ofkeccak256(abi.encode(ChannelConfig))exactextra.assetTransferMethodcan be omitted fromPaymentRequiredfor default method selectionextraobjects include token domain metadata but no transfer-method selectorWhy
This addresses #2323. The previous wording could send external implementers toward an incompatible channel id derivation, and the EVM exact examples made
assetTransferMethodlook required even though canonicalPaymentRequiredexamples omit it.Verification
git diff --checkpnpm exec prettier -c .prettierrc --check src/batch-settlement/client/voucher.ts ../../../../specs/schemes/exact/scheme_exact_evm.md ../../../../specs/transports-v2/http.md ../../../../specs/x402-specification-v2.mdfromtypescript/packages/mechanisms/evmpnpm --filter @x402/evm lint:checkNotes
pnpm --filter @x402/evm test -- --runInBandcurrently fails locally before exercising this docs change because the package-level Vitest run cannot resolve workspace imports such as@x402/core/http,@x402/core/client, and@x402/core/utilsin this checkout. The collected unit tests that did not hit those aliases passed.