fix(mcp): preserve existing metadata#2318
Open
EfeDurmaz16 wants to merge 2 commits into
Open
Conversation
|
@EfeDurmaz16 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
e685e37 to
572b03e
Compare
Signed-off-by: EfeDurmaz16 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves existing MCP
_metafields when x402 attaches payment request or settlement metadata.MCP
_metacan carry non-payment context such as trace IDs, auth hints, evidence handles, or other transport metadata. The current helpers and server wrapper replace_metawhen adding x402 metadata, which can drop that context.Changes
_metainattachPaymentToMeta_metainattachPaymentResponseToMeta_metawhencreatePaymentWrapperattaches settlement response metadataVerification
pnpm --dir typescript --filter @x402/mcp exec vitest run test/unit/utils.test.ts test/unit/server.test.tspnpm --dir typescript --filter @x402/mcp lint:checkgit diff --checkNote: the full
pnpm --dir typescript --filter @x402/mcp testsuite currently fails intest/unit/client.test.tsbecause@x402/core/schemascannot be resolved fromsrc/client/x402MCPClient.tsin this local workspace setup. The two test files covering this change pass.