-
Notifications
You must be signed in to change notification settings - Fork 71
Add ability to upload mappings/symbols file #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
604653f
3a2a6cb
216dc21
b4db7f1
f5ee30f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,15 @@ | ||
| name: Sample workflow for App Center action | ||
| on: [push, pull_request, workflow_dispatch] | ||
| on: [ push, pull_request, workflow_dispatch ] | ||
| jobs: | ||
| run: | ||
| android: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| uses: actions/checkout@v2 | ||
| - name: Get sample .apk for test purposes | ||
| run: wget --output-document ApiDemos-debug.apk https://github.com/appium/appium/blob/906350fd335f9485376214fdd17c7cdb6c9ff26b/sample-code/apps/ApiDemos-debug.apk?raw=true | ||
| run: wget https://github.com/appium/appium/blob/906350fd335f9485376214fdd17c7cdb6c9ff26b/sample-code/apps/ApiDemos-debug.apk?raw=true -O ApiDemos-debug.apk | ||
| - name: Get sample mappings.txt file for test purposes | ||
| run: wget https://gist.githubusercontent.com/loopj/43a4a3231f32c17ab9e3/raw/2181ad9ae926cd3d46ee9becabcb0cce668ef9c0/mapping.txt -O mappings.txt | ||
| - name: Upload artifact with provided release notes | ||
| uses: ./ | ||
| with: | ||
|
|
@@ -47,4 +49,29 @@ jobs: | |
| group: Collaborators | ||
| file: ApiDemos-debug.apk | ||
| debug: true | ||
|
|
||
| - name: Upload apk artifact with mappings file | ||
| uses: ./ | ||
| with: | ||
| appName: ${{ secrets.APP_NAME }} | ||
| token: ${{ secrets.API_TOKEN }} | ||
| group: Collaborators | ||
| file: ApiDemos-debug.apk | ||
| mappings: mappings.txt | ||
| releaseNotes: Has mappings | ||
| debug: true | ||
| ios: | ||
wzieba marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
| - name: Get sample .ipa file for test purposes | ||
| run: wget https://github.com/bitbar/test-samples/blob/master/apps/ios/bitbar-ios-sample.ipa?raw=true -O sample-ios-app.ipa | ||
| - name: Upload ipa artifact with symbols file | ||
| uses: ./ | ||
| with: | ||
| appName: ${{ secrets.IOS_APP_NAME }} | ||
| token: ${{ secrets.IOS_API_TOKEN }} | ||
|
Comment on lines
+72
to
+73
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. iOS apps cannot be uploaded to the same project as android ones |
||
| group: Collaborators | ||
| file: sample-ios-app.ipa | ||
wzieba marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| releaseNotes: Has symbols | ||
| debug: true | ||
wzieba marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .idea/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,16 @@ | ||
| FROM node:12.10.0-alpine | ||
| FROM node:14 | ||
wzieba marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| WORKDIR /app | ||
| COPY . /app | ||
|
|
||
| RUN npm install -g appcenter-cli@2.5.4 \ | ||
| && apk update \ | ||
| && apk add git \ | ||
| && apk add bash | ||
| RUN npm install -g appcenter-cli@2.5.4 | ||
|
|
||
| RUN mkdir -p /usr/local/lib/aapt/ | ||
| RUN wget -q "https://dl.google.com/dl/android/maven2/com/android/tools/build/aapt2/4.0.1-6197926/aapt2-4.0.1-6197926-linux.jar" -O aapt2-all.jar \ | ||
| && mv aapt2-all.jar /usr/local/lib/aapt/aapt2-all.jar \ | ||
| && cd /usr/local/lib/aapt \ | ||
| && unzip -qq aapt2-all.jar \ | ||
| && ln -s /usr/local/lib/aapt/aapt2 /usr/local/bin/aapt2 | ||
|
Comment on lines
+9
to
+13
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the [documentation(https://developer.android.com/studio/command-line/aapt2#download_aapt2) to use aapt it is required to download the jar and extract it. The jar itself isn't executable 🤷
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another thing here is the location where the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And one more thing is that I'm creating a symlink on a path that belongs to PATH as I wanted to make it executable everywhere, but for some reason I couldn't make it to work 🤷 If anyone has any idea why it didn't work in the bash script I'd love to know. |
||
|
|
||
| RUN chmod +x /app/entrypoint.sh | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ This action uploads artifacts (.apk or .ipa) to Visual Studio App Center. | |
|
|
||
| ### `appName` | ||
|
|
||
| **Required** App name followed by username e.g. `wzieba/Sample-App` | ||
| **Required** App name preceded by the App Center's username e.g. wzieba/Sample-App | ||
|
||
|
|
||
| ### `token` | ||
|
|
||
|
|
@@ -23,9 +23,17 @@ This action uploads artifacts (.apk or .ipa) to Visual Studio App Center. | |
|
|
||
| **Required** Artifact to upload (.apk or .ipa) | ||
|
|
||
| ### `mappings` | ||
|
|
||
| Android mappings.txt file location. See [the documentation](https://developer.android.com/studio/build/shrink-code) for details | ||
|
|
||
| ### `symbols` | ||
|
|
||
| iOS debug symbol file (.dSYM) location. See [the documentation](https://docs.microsoft.com/en-us/appcenter/diagnostics/ios-symbolication) for details | ||
|
|
||
| ### `releaseNotes` | ||
|
|
||
| Release notes visible on release page | ||
| Release notes visible on App Center's Release page | ||
|
|
||
| ### `gitReleaseNotes` | ||
|
|
||
|
|
@@ -46,6 +54,7 @@ See Github Actions [documentation](https://docs.github.com/en/actions/creating-a | |
|
|
||
| ## Sample usage | ||
|
|
||
| Android: | ||
| ``` | ||
| name: Build, code quality, tests | ||
|
|
||
|
|
@@ -71,7 +80,37 @@ jobs: | |
| token: ${{secrets.APP_CENTER_TOKEN}} | ||
| group: Testers | ||
| file: app/build/outputs/apk/release/app-release-unsigned.apk | ||
| mappings: app/build/outputs/mappings/release/mappings.txt | ||
| notifyTesters: true | ||
| debug: false | ||
| ``` | ||
|
|
||
| iOS | ||
| ``` | ||
| name: Build, code quality, tests | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: set up JDK 1.8 | ||
| uses: actions/setup-java@v1 | ||
| with: | ||
| java-version: 1.8 | ||
| - name: build release | ||
| run: ./gradlew assembleRelease | ||
| - name: upload artefact to App Center | ||
| uses: wzieba/AppCenter-Github-Action@v1 | ||
| with: | ||
| appName: wzieba/Sample-App | ||
| token: ${{secrets.APP_CENTER_TOKEN}} | ||
| group: Testers | ||
| file: path/to/iOS.ipa | ||
| symbols: path/to/crash_symbols.dSYM | ||
| notifyTesters: true | ||
| ``` | ||
Uh oh!
There was an error while loading. Please reload this page.