fix(storage): resolve workspace protocol in published package #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for creative-fairy-df92c4 failed.
|
|
The root cause isn't in the code, but in the publishing tool. Using |
|
Merge this ASAP please. |
|
Superseded by #1943, which implemented the correct fix (and should be released pretty soon) |
|
I've deprecated the bad version on NPM, I'll fix this by fixing the publishing workflow. Thanks for opening the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The latest version of
@wxt-dev/storage(v1.2.5) was published with an internal"@wxt-dev/browser": "workspace:^"dependency. This breaks the installation for end-users, as it's an unresolved workspace protocol.This PR directly replaces the
workspace:^protocol in the sourcepackage.jsonwith a concrete version range (^0.1.4). This ensures that theunbuildprocess generates a correctpackage.jsonfor publishing, resolving the installation error.Manual Testing
I have verified this fix locally by running
pnpm packand inspecting the resultingpackage.jsonin the tarball to confirm the protocol was correctly replaced. All project tests (pnpm test) also pass.Related Issue
This PR closes #1933