Skip to content

Conversation

@aeharding
Copy link
Contributor

@aeharding aeharding commented Sep 30, 2025

Overview

The data-wxt-* attribute is unnecessary and seems to only be used for testing purposes. So, I've removed it and updated the tests.

Manual Testing

None.

Related Issue

This PR closes #1912

@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 9145fee
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/68dcbbdab2dc2400088a9476
😎 Deploy Preview https://deploy-preview-1913--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aeharding aeharding changed the title fix: remove data-wxt-* attributes feat: remove data-wxt-* attributes Oct 1, 2025
Copy link
Member

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure why I added that. Hopefully this won't cause any issues, I can't think of any... it's not a documented feature at least, so I'm good with removing it without a breaking change notice.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.39%. Comparing base (bb67910) to head (9145fee).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
+ Coverage   81.12%   81.39%   +0.27%     
==========================================
  Files         131      131              
  Lines        6680     6677       -3     
  Branches     1097     1096       -1     
==========================================
+ Hits         5419     5435      +16     
+ Misses       1251     1232      -19     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 27, 2025

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1913

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1913

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1913

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1913

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1913

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1913

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1913

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1913

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@1913

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1913

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1913

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1913

wxt

npm i https://pkg.pr.new/wxt@1913

commit: 9145fee

@aklinker1 aklinker1 merged commit 36a5015 into wxt-dev:main Oct 27, 2025
19 checks passed
@github-actions
Copy link
Contributor

Thanks for helping make WXT better!

@aeharding aeharding deleted the remove-data-wxt branch October 27, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't set the data-wxt-shadow-root attribute

3 participants