-
-
Couldn't load subscription status.
- Fork 408
feat: remove data-wxt-* attributes
#1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
data-wxt-* attributesdata-wxt-* attributes
878f7f9 to
9145fee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not sure why I added that. Hopefully this won't cause any issues, I can't think of any... it's not a documented feature at least, so I'm good with removing it without a breaking change notice.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
+ Coverage 81.12% 81.39% +0.27%
==========================================
Files 131 131
Lines 6680 6677 -3
Branches 1097 1096 -1
==========================================
+ Hits 5419 5435 +16
+ Misses 1251 1232 -19
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
|
Thanks for helping make WXT better! |
Overview
The
data-wxt-*attribute is unnecessary and seems to only be used for testing purposes. So, I've removed it and updated the tests.Manual Testing
None.
Related Issue
This PR closes #1912