Fix comment for default publicDir location#1519
Closed
namuorg wants to merge 1 commit intowxt-dev:mainfrom
namuorg:public-dir
Closed
Fix comment for default publicDir location#1519namuorg wants to merge 1 commit intowxt-dev:mainfrom namuorg:public-dir
namuorg wants to merge 1 commit intowxt-dev:mainfrom
namuorg:public-dir
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
FYI, It's updating to rootDir indeed #1209 (comment) |
Contributor
Author
Oh great! I was a bit puzzled by why it was in the src dir rather than the root so this context is nice to have. Glad to hear that it’ll be changing to the root dir. I’ll close this out since this will be reverted anyway with the upcoming change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The documentation for
publicDirsays that the default value is${config.root}/publicbut it should be${config.srcDir}/public