SLT-1193: Drupal chart: Remove deprecated mailhog service from the chart #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4lv15
force-pushed
the
feature/SLT-1193-rm-mail
branch
from
72b7beb to
80001c5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated mailhog configuration and references from the Drupal chart and related files in favor of the mailpit service.
- Removed mailhog configuration and schema definitions
- Removed mailhog-related templating blocks and dependency entries
- Updated CI configuration to stop fetching mailhog dependencies
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/drupal/values.yaml | Removed mailhog configuration settings |
| charts/drupal/values.schema.json | Removed mailhog schema definitions |
| charts/drupal/templates/varnish-configmap-vcl.yaml | Removed mailhog-related VCL logic |
| charts/drupal/templates/smtp-secret.yaml | Updated conditional to no longer check mailhog |
| charts/drupal/templates/drupal-configmap.yaml | Removed mailhog route definitions and linked mailpit |
| charts/drupal/templates/checks.yaml | Modified checks; production failure now applies to mailpit |
| charts/drupal/templates/_helpers.tpl | Removed mailhog conditions and updated helper logic |
| charts/drupal/templates/NOTES.txt | Removed mailhog instructions, kept mailpit instructions |
| charts/drupal/Chart.yaml | Removed mailhog dependency |
| .circleci/config.yml | Removed helm repo addition for mailhog |
Comments suppressed due to low confidence (1)
charts/drupal/templates/checks.yaml:4
- The production check will cause deployments to fail if mailpit is enabled, but the PR description indicates that mailpit should operate in production. Please update or remove this check accordingly.
{{- fail "Mailpit should not be enabled in production" -}}
|
Postponed until mailhog is properly deprecated in #749, marking as draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
How to test: