dockerignore file location change #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jancis
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Dockerignore configuration by moving Dockerignore files to Dockerfile-specific locations. Key changes include:
- Updating the orb version reference from "silta/silta@dev:master" to "silta/silta@dev:gitignore".
- Ensuring dependency alignment with the linked PR wunderio/silta-circleci#207.
Files not reviewed (2)
- silta/php.Dockerfile.dockerignore: Language not supported
- silta/shell.Dockerfile.dockerignore: Language not supported
Comments suppressed due to low confidence (1)
.circleci/config.yml:4
- Verify that the updated orb version 'silta/silta@dev:gitignore' fully reflects the changes required for Dockerignore file relocation and update any relevant documentation to avoid confusion.
silta: silta/silta@dev:gitignore
Rade333
approved these changes
May 5, 2025
Rade333
reviewed
May 5, 2025
|
|
||
| orbs: | ||
| silta: silta/silta@dev:master | ||
| silta: silta/silta@dev:gitignore |
Contributor
There was a problem hiding this comment.
I removed this change in the release branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerignore files moved to Dockerfile-specific dockerignore files.
This depends on: wunderio/silta-circleci#207