Update silta.yml #721
Update silta.yml #721
Conversation
Setting enableServiceLinks: false by default due to performance issues on namespaces with lot of environment values.
Setting enableServiceLinks: false by default due to performance issues on namespaces with lot of environment values.
removed redis configuration settings. was in the wrong place
There was a problem hiding this comment.
When testing this the redis container still has enableServiceLinks as true. Please check.
My test deployment based on this branch: https://app.circleci.com/pipelines/github/wunderio/drupal-project-k8s/6484/workflows/1c221078-5875-4936-bf27-926168d20a9e
There was a problem hiding this comment.
Pull Request Overview
This PR updates the settings in the drupal Helm chart values file to disable service links by default for performance optimization on namespaces with many environment values.
- Added "enableServiceLinks: false" under the replica, master, and sentinel redis configuration sections.
| @@ -702,17 +702,21 @@ redis: | |||
| # mandatory value | |||
| password: "" | |||
| replica: | |||
| enableServiceLinks: false | |||
There was a problem hiding this comment.
There are trailing whitespace characters on this line. It is recommended to remove extra spaces to maintain consistency.
| enableServiceLinks: false | |
| enableServiceLinks: false |
Copilot uses AI. Check for mistakes.
| # replicaCount: 1 | ||
| autoscaling: | ||
| enabled: false | ||
| master: | ||
| enableServiceLinks: false |
There was a problem hiding this comment.
There are trailing whitespace characters on this line. Removing the extra spaces can help ensure a cleaner YAML format.
| enableServiceLinks: false | |
| enableServiceLinks: false |
Copilot uses AI. Check for mistakes.
| memory: 256Mi | ||
| memory: 256Mi | ||
| sentinel: | ||
| enableServiceLinks: false |
There was a problem hiding this comment.
There is trailing whitespace on this line as well. It is suggested to clean up the extra space for consistency.
| enableServiceLinks: false | |
| enableServiceLinks: false |
Copilot uses AI. Check for mistakes.
Setting enableServiceLinks: false by default due to performance issues on namespaces with lot of environment values.