-
Notifications
You must be signed in to change notification settings - Fork 197
fix: codecov carryforward paths are not detected #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated a GitHub Actions workflow step label and revised the repository Codecov config: standardized flag paths to directory-style entries with trailing slashes, adjusted composition carryforward, and added comment-related configuration keys (layout/behavior/requirements). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/protographic.yaml(1 hunks)codecov.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
codecov.yaml
[error] 46-46: syntax error: found unexpected end of stream
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
.github/workflows/protographic.yaml (1)
44-51: Step label clarification looks good.The label change from "Upload integration results to Codecov" to "Upload test results to Codecov" better reflects the actual content being uploaded. Action parameters and inputs remain unchanged.
codecov.yaml (1)
17-17: Standardized flag paths with trailing slashes for carryforward detection.The addition of trailing slashes (router/, cli/, studio/, etc.) standardizes the path format for directory-style matching, which should improve Codecov's ability to detect and match paths during carryforward. This aligns with the PR objective.
Please verify that these standardized paths are correctly recognized by Codecov's carryforward feature in your test environment.
Also applies to: 21-21, 25-25, 29-29, 33-33, 37-37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
===========================================
+ Coverage 62.31% 90.55% +28.23%
===========================================
Files 295 16 -279
Lines 41134 3271 -37863
Branches 4194 871 -3323
===========================================
- Hits 25634 2962 -22672
+ Misses 15480 309 -15171
+ Partials 20 0 -20 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist