-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Windows Support #150
Some Windows Support #150
Conversation
Fixed build number and OS version for Windows. Signed-off-by: Mike Lloyd <[email protected]>
Mostly fixed character encoding and stuff. Signed-off-by: Mike Lloyd <[email protected]>
fixed conflict. Signed-off-by: Mike Lloyd <[email protected]>
I have no way to test this out. It would be great to have this code-reviewed and corroborated by a few other people. |
Sure. There's no rush. |
One question I'm not clear on from the code: how does it know which platform to load? For example, with |
Also, could you rebase against master for me? Once I understand this a bit better and the rebase is done, I'll merge it in. Thanks! |
@senorprogrammer when you do |
Awesome. Thank you for the explanation. If you're able to rebase this against master, I'll merge it in. |
Just touching base. No hurry, when you're able to rebase this against master, I'll merge it right in. |
Should be good now. I really meant to do this on a branch. Next time I will do so. |
Also, feel free to ping me for Windows stuff down the road since that's my domain. It's a nifty tool and would love to see better support for it. |
Signed-off-by: Mike Lloyd <[email protected]>
Travis is failing because you have |
The following errors:
TravisCI runs on Linux and the changes you've made are now Mac & Windows-only. Take a look at the way In the meantime I'll look into getting TravisCI to present useful error messages somehow. |
I think it would be good to cross-compile, but I'm not sure what that would look like on Travis. |
Got it working. Thanks for making this PR! |
Starts to fix #103. Not sure what full support would look like, but this is a start. In retrospect, I likely should've branched instead of doing this on master.