Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email scope to auth config. #7751

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

Malith-19
Copy link
Contributor

Purpose

  • $subject
  • Need to add this because we need to get the email in the id token for asgardeo.

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@@ -340,7 +340,7 @@
clientID: "<%= htmlWebpackPlugin.options.clientID %>",
baseUrl: getApiPath(),
responseMode: "query",
scope: ["openid SYSTEM profile"],
scope: ["openid SYSTEM profile email"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't including SYSTEM or profile send email in the id token?

Copy link
Contributor Author

@Malith-19 Malith-19 Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No at the moment.

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (eafa9eb) to head (a44d30d).
Report is 289 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7751   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      230      217   -13     
=======================================
  Hits          393      393           
- Misses        502      546   +44     
+ Partials       44        0   -44     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@JayaShakthi97 JayaShakthi97 merged commit 3f2392d into wso2:master Feb 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants