-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email scope to auth config. #7751
Add email scope to auth config. #7751
Conversation
@@ -340,7 +340,7 @@ | |||
clientID: "<%= htmlWebpackPlugin.options.clientID %>", | |||
baseUrl: getApiPath(), | |||
responseMode: "query", | |||
scope: ["openid SYSTEM profile"], | |||
scope: ["openid SYSTEM profile email"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't including SYSTEM or profile send email in the id token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No at the moment.
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7751 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 42 42
Lines 939 939
Branches 230 217 -13
=======================================
Hits 393 393
- Misses 502 546 +44
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. |
Purpose
Checklist
Security checks