Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the content of the confirmation model for sms provider deletion. #7748

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Feb 25, 2025

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (eafa9eb) to head (0d61257).
Report is 278 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7748   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      230      230           
=======================================
  Hits          393      393           
  Misses        502      502           
  Partials       44       44           
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ThaminduDilshan
Copy link
Contributor

Let's validate no e2e failures are there with this

@Malith-19
Copy link
Contributor Author

Let's validate no e2e failures are there with this

Currently we don't have any negative cases for sms provider deletion in https://github.com/wso2-enterprise/asgardeo-tests/blob/6f8787022362d75e9ad4fd857e2524cd5da942ea/cypress/e2e/25-sms-provider/25.01-admin_can_configure_sms_provider.spec.ts

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13528623666

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13528623666
Status: failure

@ThaminduDilshan ThaminduDilshan merged commit 32cddd7 into wso2:master Feb 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants