Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show SCIM2 custom schema tab by default #7746

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

@amanda-ariyaratne amanda-ariyaratne commented Feb 25, 2025

Purpose

Shows the Custom Schema tab in SCIM 2 view by default, even if the custom dialect is not created. This provides the option to create a custom SCIM attribute without having to add a local attribute.

Before

Screen.Recording.2025-02-25.at.13.59.48.mov

After

Screen.Recording.2025-02-25.at.14.01.35.mov

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (a0d2fba) to head (1742ff7).
Report is 54 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7746   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      230      217   -13     
=======================================
  Hits          393      393           
- Misses        502      546   +44     
+ Partials       44        0   -44     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

DonOmalVindula
DonOmalVindula previously approved these changes Feb 27, 2025
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@amanda-ariyaratne amanda-ariyaratne merged commit 4bd356b into wso2:master Feb 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants