Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[development] Update webpack rewrite logic to facilitate pre-auth in local development #7598

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

JayaShakthi97
Copy link
Contributor

@JayaShakthi97 JayaShakthi97 commented Feb 11, 2025

Purpose

$subject for serving apps as static apps.

Improvements need to be made to the My Account app as well.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (7e3fe5a) to head (e65abae).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7598   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      217      238   +21     
=======================================
  Hits          393      393           
  Misses        546      546           
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pavinduLakshan pavinduLakshan changed the title [development] Update webpack rewrite logic to facilitate pre-auth [development] Update webpack rewrite logic to facilitate pre-auth in local development Feb 11, 2025
@JayaShakthi97
Copy link
Contributor Author

@pavinduLakshan please note that this PR is not ready to review yet

@wso2 wso2 deleted a comment from JayaShakthi97 Feb 12, 2025
@JayaShakthi97 JayaShakthi97 marked this pull request as ready for review February 28, 2025 06:39
@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

@JayaShakthi97 JayaShakthi97 merged commit 4514b9a into wso2:master Feb 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants