Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional View Access For Discoverable Applications in MyAccount #7399

Merged
merged 15 commits into from
Mar 1, 2025

Conversation

DilshanSenarath
Copy link
Contributor

@DilshanSenarath DilshanSenarath commented Jan 25, 2025

Purpose

This update will implement the necessary UI changes for discoverable applications based on the groups assigned to the application.

Related Issue

UI

image image image

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (5154ea0) to head (ff206cc).
Report is 133 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7399   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      238      238           
=======================================
  Hits          393      393           
+ Misses        546      502   -44     
- Partials        0       44   +44     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Copy link
Member

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a screenshot/screencast of the final UI once the PR is ready.

PS: Add changeset too :P

@DilshanSenarath DilshanSenarath marked this pull request as ready for review February 23, 2025 09:46
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@DilshanSenarath DilshanSenarath merged commit 886b670 into wso2:master Mar 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants