-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard Certificate Validation Management API #834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamodaaw
reviewed
Feb 7, 2025
pamodaaw
reviewed
Feb 7, 2025
...o2/carbon/identity/api/server/certificate/validation/management/v1/util/ModelMapperUtil.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Feb 7, 2025
...o2/carbon/identity/api/server/certificate/validation/management/v1/util/ModelMapperUtil.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Feb 7, 2025
...o2/carbon/identity/api/server/certificate/validation/management/v1/util/ModelMapperUtil.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Feb 7, 2025
.../validation/management/v1/factories/ServerCertificateValidationManagementServiceFactory.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Feb 7, 2025
...pi/server/certificate/validation/management/v1/impl/CertificateValidationApiServiceImpl.java
Outdated
Show resolved
Hide resolved
pamodaaw
previously approved these changes
Feb 7, 2025
pamodaaw
previously approved these changes
Feb 7, 2025
pamodaaw
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
API - https://app.swaggerhub.com/apis-docs/SachinMamoru-42f/X509-Certificate-Authenticator/v3#/
This pull request introduces a new API for certificate validation management, including the addition of new classes and configuration files. The most important changes include the creation of a service holder class, the definition of the API endpoints, and the configuration of the project dependencies and build plugins.
New API and Service Implementation:
CertificateValidationManagementServiceHolder.java
: Added a service holder class to manage theCertificateValidationManagementService
OSGi service.CertificateValidationApi.java
: Defined the API endpoints for managing CA certificates and certificate revocation validators, including methods for adding, deleting, updating, and retrieving certificates and validators.CertificateValidationApiService.java
: Created an interface for the certificate validation API service, outlining the methods to be implemented for handling certificate validation operations.Project Configuration:
pom.xml
(common): Added the project configuration for theorg.wso2.carbon.identity.api.server.certificate.validation.management.common
module, including dependencies and build plugins.pom.xml
(v1): Added the project configuration for theorg.wso2.carbon.identity.api.server.certificate.validation.management.v1
module, including dependencies and build plugins.