Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log improvements for Websocket throttling with updating unit tests #12716

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Log improvements for Websocket throttling with updating unit tests #12716

merged 3 commits into from
Jan 28, 2025

Conversation

BiyonFernando
Copy link
Contributor

Purpose

Introduce debug logs for all the websocket API throttling scenarios.
Logs will including following information

  1. Api context and version
  2. User
  3. Reason for throttling (application/subscription/api level)
  4. Channel id

Related Issues - wso2/api-manager#3292

Approach

  • Introduce apiContext, user attributes for the WebSocketThrottleResponseDTO
  • Log above data as debug when a inbound or outbound Websocket frame is throttled
  • Unit tests are updated by mocking new util method

senthuran16
senthuran16 previously approved these changes Jan 24, 2025
View reviewed changes
@Arshardh Arshardh merged commit ac42326 into wso2:master Jan 28, 2025
9 of 13 checks passed
@hisanhunais hisanhunais mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senthuran16 senthuran16 senthuran16 approved these changes

@Arshardh Arshardh Arshardh approved these changes

@tharindu1st tharindu1st Awaiting requested review from tharindu1st tharindu1st is a code owner

@AnuGayan AnuGayan Awaiting requested review from AnuGayan AnuGayan is a code owner

@chamilaadhi chamilaadhi Awaiting requested review from chamilaadhi chamilaadhi is a code owner

@dushaniw dushaniw Awaiting requested review from dushaniw dushaniw is a code owner

@tgtshanika tgtshanika Awaiting requested review from tgtshanika tgtshanika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BiyonFernando @Arshardh @senthuran16