Merge pull request #12612 from ashanhr/master

Improve Error Logging
wso2 · Oct 5, 2024 · ec9973a · ec9973a
2 parents 3da67c1 + aead2ee
commit ec9973a
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/.../org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java b/.../org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java
@@ -14030,12 +14030,10 @@ public List<BlockConditionsDTO> getBlockConditions(String tenantDomain) throws A
                 try {
                     connection.rollback();
                 } catch (SQLException ex) {
-                    throw new APIManagementException("Failed to rollback getting Block conditions.",
-                            ExceptionCodes.BLOCK_CONDITION_RETRIEVE_FAILED);
+                    handleException("Failed to rollback getting Block conditions.", ex);
                 }
             }
-            throw new APIManagementException("Failed to retrieve all block conditions for the tenant " + tenantDomain,
-                    ExceptionCodes.BLOCK_CONDITION_RETRIEVE_FAILED);
+            handleException("Failed to retrieve all block conditions for the tenant " + tenantDomain, e);
         } finally {
             APIMgtDBUtil.closeAllConnections(selectPreparedStatement, connection, resultSet);
         }
@@ -14086,9 +14084,9 @@ public List<BlockConditionsDTO> getBlockConditionsByConditionTypeAndValue(String
                 blockConditionsDTOList.add(blockConditionsDTO);
             }
         } catch (SQLException e) {
-            throw new APIManagementException(
-                    "Failed to get Block conditions by condition type: " + conditionType + " and condition value: "
-                            + conditionValue, ExceptionCodes.BLOCK_CONDITION_RETRIEVE_FAILED);
+            handleException(
+                    "Failed to get Block conditions by condition type: " + conditionType + " and condition value: " + conditionValue,
+                    e);
         } finally {
             APIMgtDBUtil.closeAllConnections(selectPreparedStatement, connection, resultSet);
         }