Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid flow for configuring multiple hybrid flow response types #2677

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

Thumimku
Copy link
Contributor

Proposed changes in this pull request

Issue: wso2/product-is#21140

HybridFlowConfigVideo.mp4
Screenshot 2025-01-18 at 18 45 43

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12844362203

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.67%. Comparing base (c383ee3) to head (f895ba6).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
...rg/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java 83.33% 2 Missing and 1 partial ⚠️
...dentity/oauth/config/OAuthServerConfiguration.java 60.00% 1 Missing and 1 partial ⚠️
...lidators/AbstractResponseTypeRequestValidator.java 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2677      +/-   ##
============================================
- Coverage     56.16%   54.67%   -1.50%     
- Complexity     8246     8830     +584     
============================================
  Files           631      642      +11     
  Lines         46817    51259    +4442     
  Branches       9048    10063    +1015     
============================================
+ Hits          26296    28025    +1729     
- Misses        16746    19217    +2471     
- Partials       3775     4017     +242     
Flag Coverage Δ
unit 39.19% <78.12%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12844362203
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12844362203

# Conflicts:
#	components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/authz/validators/AbstractResponseTypeRequestValidator.java
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12921003179

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12921003179
Status: failure

@Thumimku
Copy link
Contributor Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/12921003179 Status: failure

These failures not related to hybrid flow. but anyway doing it again.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12922591727

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12922591727
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12922591727

shashimalcse
shashimalcse previously approved these changes Jan 23, 2025
@Thumimku Thumimku merged commit 6302820 into wso2-extensions:master Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants