Open
Conversation
as it is limiting activities to a portrait orientation, but they are working acceptably for landscape orientation as well. Orientation configuration changes should be managed correctly; as the application stands, navigation flips to the Devices tab when orientation changes, instead of persisting in the current tab.
Splits the buttons in two clusters. Right cluster mimics the original Roku navigation cluster. Left cluster groups tv/media and unconventional or elite buttons.
Kind of hackish: https://stackoverflow.com/a/5317727 and https://stackoverflow.com/a/23363016 So, now that a horizontal layout has been added, when the orientation changes, we retain the selected tab/item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use my tablet in landscape mode all of the time, supported on top of the keyboard. Applications that don't support a landscape orientation can be quite irritating to me, so I enabled the landscape orientation on the activites and wrote an alternate layout for a landscape orientation on big screens to make better use of the screen real estate. The other views look fine on landscape, so no changes were needed there.
A pending issue is a remote controller layout that works well with small screens on landscape. I suppose we would have to get rid of the tab switcher (or make it vertical) and the top title to maximize the area available for the buttons.