WIP/MAINT: Use scipy.signal instead of skimage for downscale #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency scikit-image
ksunden
requested review from
darienmorrow,
ddkohler and
untzag
as code owners
|
We may consider playing with adding parameters to control behavior, in particular, since this is doing some filtering, it can have effects outside of the window of interest, rather than simply averaging the points. This also changes behavior to preserve all variables, and apply the same decimate averaging, instead of just directly downsampling. |
|
If merged, requires editing the conda-forge recipe on next release, as dependency list is repeated there |
ksunden
added a commit
that referenced
this pull request
Jan 16, 2019
Alternative implementation to #862
ksunden
changed the title
untzag
pushed a commit
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency scikit-image
Supercedes #860 (needed for testing on travis)