Skip to content

Conversation

ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Oct 25, 2021

Changes

from_solis: imports "kinetic series" type data, which has multiple camera images. The camera images are stacked along the new axis "frame".

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

imports series working example
@ddkohler ddkohler changed the title WIP: Update _solis.py WIP: from_Solis: import kinetic series type Oct 25, 2021
@ddkohler ddkohler changed the title WIP: from_Solis: import kinetic series type from_Solis: import kinetic series type Oct 25, 2021
@ddkohler ddkohler marked this pull request as ready for review October 25, 2021 20:38
@ddkohler
Copy link
Contributor Author

Check failure seems unrelated to the code changes. @ksunden anything to worry about?

@ksunden
Copy link
Member

ksunden commented Oct 25, 2021

Does this have any relation to #973?

@ddkohler
Copy link
Contributor Author

@ksunden somewhat related. In this PR, import discovers the data shape by inspecting the ascii array. One could determine the acquisition type/data shape from the metadata (fields Acquisition Mode, Number in Kinetic Series), so importing this acquisition type from metadata is a possible strategy. Metadata is optional in Solis exports, so importing based solely on metadata is not reliable.

@kameyer226
Copy link
Contributor

does anyone know how long the method get_frames takes to actually get the frames? I haven't been impressed with Python's speed of handling for and while loops...reminds me of Matlab.

@ddkohler
Copy link
Contributor Author

@kameyer226 from experience I can say that for "large" files (hundreds of MB) the whole import function can take seconds. I haven't been too concerned with run times of file opening, since they only need to be run once (after that they can be saved as wt5 files).

@untzag
Copy link
Member

untzag commented Oct 26, 2021

@ddkohler looks like we are removing support for a previous txt format? Is that intended?

@ddkohler
Copy link
Contributor Author

@untzag I did changed the docstring, but support has not changed. I felt the docstring was misleading. Solis software exports readable files with an .asc suffix--there are never .txt files involved.

@kameyer226 kameyer226 merged commit da1efc6 into master Oct 26, 2021
@kameyer226 kameyer226 deleted the from-solis_kinetic branch October 26, 2021 22:26
@ddkohler ddkohler restored the from-solis_kinetic branch October 26, 2021 22:49
@ddkohler ddkohler deleted the from-solis_kinetic branch October 26, 2021 22:50
@ddkohler ddkohler mentioned this pull request Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants