Adding WRF-Hydro PRs

[scrasmussen]

TYPE: bugfix, enhancement

KEYWORDS: syncing WRF-Hydro/hydro, gage-assisted diversion, bugfixes

SOURCE: internal hydro team + contributor

• Soren Rasmussen, NSF NCAR
• Ryan Cabell, NSF NCAR
• Andrew Song, Inner Mongolia Meteorological Service / China Meteorological Administration (Wrote PR#829)

DESCRIPTION OF CHANGES: This PR updates the hydro directory to the NCAR/wrf_hydro_nwm_public repository. It includes the following PRs

• Add initial support for gage-assisted diversions in channel routing NCAR/wrf_hydro_nwm_public#756
• bugfix: Diversions Makefiles for configure build NCAR/wrf_hydro_nwm_public#811
• Revert TYPEL(k) check NCAR/wrf_hydro_nwm_public#816
• bugfix: make clean new directories NCAR/wrf_hydro_nwm_public#823
• Enhancement: .f90 to .F90. Avoid compilation errors. NCAR/wrf_hydro_nwm_public#829
• enhancement: Dropping .exe extension from wrf_hydro binary NCAR/wrf_hydro_nwm_public#827
• Properly handle unexpected NaNs in diversion observations NCAR/wrf_hydro_nwm_public#855
• Make diversion initialization errors non-fatal warnings NCAR/wrf_hydro_nwm_public#856
• bugfix: type mismatch when nudging turned on NCAR/wrf_hydro_nwm_public#861
• bugfix: nudging io dependency NCAR/wrf_hydro_nwm_public#862

LIST OF MODIFIED FILES:

$ git diff --name-status develop
M       hydro/CMakeLists.txt
M       hydro/CPL/WRF_cpl/CMakeLists.txt
M       hydro/Data_Rec/module_namelist.F90
M       hydro/Data_Rec/module_namelist_inc.F90
M       hydro/HYDRO_drv/module_HYDRO_drv.F90
M       hydro/Makefile
M       hydro/OrchestratorLayer/config.F90
M       hydro/Routing/CMakeLists.txt
A       hydro/Routing/Diversions/CMakeLists.txt
A       hydro/Routing/Diversions/Makefile
A       hydro/Routing/Diversions/module_diversions.F90
A       hydro/Routing/Diversions/module_diversions_timeslice.F90
M       hydro/Routing/Makefile
M       hydro/Routing/module_channel_routing.F90
M       hydro/arc/Makefile.mpp
D       hydro/arc/Makefile.seq
M       hydro/arc/macros.mpp.cray_fortran
M       hydro/arc/macros.mpp.gfort
M       hydro/arc/macros.mpp.ifort
D       hydro/arc/macros.mpp.ifort.luna
D       hydro/arc/macros.mpp.ifort.summit_has
D       hydro/arc/macros.mpp.ifort.theia
M       hydro/arc/macros.mpp.linux
D       hydro/arc/macros.seq.IBM.xlf90_r
D       hydro/arc/macros.seq.gfort
D       hydro/arc/macros.seq.ifort
D       hydro/arc/macros.seq.linux
D       hydro/arc/macros.theia.debug
D       hydro/arc/macros.yellowstone
D       hydro/arc/macros.yellowstone.debug
M       hydro/configure
M       hydro/nudging/CMakeLists.txt
A       hydro/nudging/io/CMakeLists.txt
R098    hydro/nudging/module_nudging_io.F90     hydro/nudging/io/module_nudging_io.F90
M       hydro/utils/CMakeLists.txt
A       hydro/utils/fortglob/CMakeLists.txt
A       hydro/utils/fortglob/Makefile
A       hydro/utils/fortglob/fortglob.F90
A       hydro/utils/fortglob/libfortglob.c
A       hydro/utils/fortglob/libfortglob.h

TESTS CONDUCTED: NOTE THAT THE PR IS IN DRAFT UNTIL TESTING IS COMPLETE. Current building and running

1. WRF-Hydro Front Range, CO testcase
2. Testing multiple configurations of Make and CMake build systems

RELEASE NOTE: Hydro bug fixes plus modifications to add initial support for gage-assisted diversions in channel routing, which requires a new optional Diversion netCDF parameter file. This adds a C compiler dependency

[weiwangncar]

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None