Repository navigation
W-1139: Make site exceptions work in five more Arc alternatives - #253
Merged
Merged
Conversation
Per-site exceptions only apply in apps on the known-browser list, and Phi wasn't on it, so a site exception never matched there. Adds Phi and Phi Canary, plus the Arc alternatives with a macOS build, 1,000+ GitHub stars and recent activity: Search, Ora, Nook, Zephium, Ardia, Crest, Surf and Flow. Each ID comes from the browser's own release build settings in its public repo. Refs: W-1139
Their browser UI is itself a web page in the same window as the tabs, so the AX walk would likely return the UI's internal address (surf-internal://, flow-internal://, tauri://) instead of the page's, and no exception could match. Surf has also had no commits since May, and Flow is being replaced by a rewrite. Refs: W-1139
Phi's Chromium content doesn't show up in the accessibility tree, even after setting AXManualAccessibility or AXEnhancedUserInterface, and its AppleScript dictionary has no tab address. Mojito can't read the page address there, so listing it only adds a wasted tree walk per capture.
wr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Site exceptions should now apply in five browsers people are moving to as Arc winds down: Search, Ora and Nook, which are built on Safari's engine, and Ardia and Crest, which are built on Chrome's. Mojito only reads the page address in apps on its list of known browsers. None of these were on that list, so a site exception never matched in them.
All five come from the Awesome Arc Alternatives list: each has a macOS build, more than 1,000 GitHub stars, and commits in the last few months. Each browser's app ID comes from the release build settings in its public repo.
Surf, Flow and Zephium also meet the star count but are left out. In each, the browser's own interface is a web page in the same window as the tabs, so Mojito would likely read the interface's internal address instead of the page's.
Phi isn't included
Phi is the browser #252 asked about, and adding it to the list doesn't help. With Phi 2.17.0 open on a page, Mojito's address lookup finds the sidebar and toolbar but nothing of the page itself. Asking Phi to switch on full accessibility, the two ways Chrome and Electron apps support, gets both requests rejected as unsupported. Phi's AppleScript dictionary has no tab address either, so the workaround Mojito uses for Arc isn't available. Listing Phi would only add a fruitless search of its window every time
:is typed. Turning Mojito off for Phi as a whole still works.Not tested in the other five
None of the five is installed on the test Mac. Mojito reads the address the same way it does in Chrome and Safari, which works when a browser exposes the page to macOS accessibility.
Test plan
scripts/run-tests.shpassesRefs W-1139