Repository navigation
Default symbols to the :: trigger on fresh installs - #225
Merged
Merged
Conversation
W-451 turned symbols on for fresh installs but blended them into the `:` emoji results (symbolsFollowEmoji = true). In that mode `::` isn't an opener at all, so the `::degree` / `::em_dash` the site, README and onboarding teach just cancels on a new install. Fresh installs (no saved triggers and no legacy symbols prefs) now get the scoped `::` trigger, and the onboarding / Settings pickers treat `::` as the symbols default. Existing installs keep whatever they have saved: the migration still maps legacy prefs the old way, and a saved config without the flag still decodes as blended. Side effect: telemetry's `triggersCustom` compared saved configs to an un-normalized default, so every blended default install reported true; fresh installs now report false. Refs: W-978
3 tasks done
wr
added a commit
that referenced
this pull request
Oct 5, 2026
* Fix stale homepage claims and add attributed download CTAs The FAQ said Mojito works in Terminal and Notion (both excluded by default) and stays out of Messages (it doesn't, and the demo shows iMessage). The customize answer still described symbols as an optional :cmd: mode, but since #225 fresh installs get them on ::. The hero demo also typed in Terminal with no hint that dev tools are opt-in, so it now shows a note while that window is up. The only download button was in the nav, so the hero and the end of the page get one each. All three homepage links go through /download with ref=home so homepage downloads are attributed like the guide pages. The Privacy section repeated the /privacy page in three paragraphs; it is now one line and a link. Every changed string is updated in all 19 locales. Refs: W-993 * Drop the Terminal demo note No one has been confused by the Terminal scene, so the caveat added noise without fixing a real problem. Refs: W-993
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a fresh install,
::degreedoes nothing. W-451 (#153) turned symbols on by default but blended them into the:emoji results (symbolsFollowEmoji = true), and in that mode::isn't a trigger at all. The README, the homepage and every guide page teach::.Change
::trigger.TriggerConfig.default.symbolsFollowEmojiis nowfalse, andTriggerConfigStore.migrateuses it when no legacy keys exist.::as the default when you clear a custom trigger.Side effect: telemetry's
triggersCustomcompared saved configs to an un-normalized default, so every blended default install reportedtrue. Fresh installs now reportfalse, so the stats page's custom-trigger share will drop. The old number was inflated.Tests
doubleColonOpensSymbolsScopeByDefaultandmigrationKeepsLegacyBlendedSymbols.TriggerStateMachineTests,TriggerMatcherTestsandTriggerConfigStoreTestspass (112 tests), run through SwiftPM with the Command Line Tools.--no-verify. Please runscripts/run-tests.shbefore merging.Refs W-978