[wpimath] Use ct_matrix instead of <Eigen/LU> for determinant in headers #7600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caught a bug in ct_matrix's 3x3 determinant.
calcmogul
force-pushed
the
wpimath-use-ct-matrix-determinant-in-headers
branch
from
eda8238 to
5f2c4a4
Compare
PeterJohnson
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Eigen/LU>doubles compilation times on MSVC, even if the Rotation3d rotation matrix constructor is unused. MSVC's frontend inefficiently parses large headers; GCC and Clang are largely unaffected.This caught a bug in ct_matrix's 3x3 determinant.