Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add check whether PR requires manual RLI updates #3672

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ci] Add check whether PR requires manual RLI updates #3672

wants to merge 4 commits into from

Conversation

Starlight220
Copy link
Member

@Starlight220 Starlight220 commented Oct 25, 2021 •
edited
Loading

The companion to this is dependant on wpilibsuite/frc-docs#1351.

@Starlight220 Starlight220 mentioned this pull request May 2, 2022
Open
@Starlight220
Copy link
Member Author

@Daltz333 I'm now reviving this PR. What should happen if the PR requires manual updating of RLIs?

@Starlight220 Starlight220 changed the title Add launcher workflow for frc-docs RLI update [ci] Add check whether PR requires manual RLI updates Oct 26, 2022
@Starlight220 Starlight220 marked this pull request as ready for review November 13, 2022 22:38
@Starlight220 Starlight220 requested a review from a team as a code owner November 13, 2022 22:38
@Starlight220
Copy link
Member Author

Tested in my fork at Starlight220#2

@calcmogul calcmogul added the build Monorepo organization, gradle/cmake, upstream_utils, etc label Nov 30, 2023
@Starlight220
Copy link
Member Author

A question here is how to sync the exclude list with the frc-docs repo

@Gold856
Copy link
Contributor

Gold856 commented Aug 1, 2024

Is there a reason why the JSON file from the frc-docs repo can't be used?

@Starlight220
Copy link
Member Author

Starlight220 commented Aug 1, 2024 •
edited
Loading

Good point, the pipeline here is very out of date with Inspector releases

@Starlight220 Starlight220 force-pushed the patch-1 branch 3 times, most recently from 53c39c8 to 88859bc Compare August 1, 2024 20:25
@Starlight220
Copy link
Member Author

This now works, but without the comment part -- which didn't work because of the pull_request/pull_request_base semantic, and I don't know when I'll have the time to work around that.

@Starlight220 Starlight220 linked an issue Aug 1, 2024 that may be closed by this pull request
[actions] Create an action that comments on PRs when code affects documentation #3068
Open
@Gold856
Copy link
Contributor

Gold856 commented Aug 4, 2024 •
edited
Loading

Lucky for you, we already have workarounds. If you look at the Comment Command workflow, you'll see that we clone the repo, then use the GitHub CLI to checkout the PR branch. This enables you to use pull_request_base to get the required permissions to comment and push commits, while also being able to checkout the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinShalit AustinShalit AustinShalit left review comments

@Daltz333 Daltz333 Awaiting requested review from Daltz333

@PeterJohnson PeterJohnson Awaiting requested review from PeterJohnson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build Monorepo organization, gradle/cmake, upstream_utils, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[actions] Create an action that comments on PRs when code affects documentation
4 participants
@Starlight220 @Gold856 @AustinShalit @calcmogul