Skip to content

UR-4297 Fix - Fatal error when saving stripe subscription plan with yearly billing cycle greater than 3 years #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MILAN88888 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

UR-4297 Fix - Fatal error when saving stripe subscription plan with yearly billing cycle greater than 3 years #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion modules/membership/includes/AJAX.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,12 @@ public static function create_membership() {
$data['membership_id'] = $new_membership_ID;
$membership_repository = new MembershipRepository();
$membership = $membership_repository->get_single_membership_by_ID( $new_membership_ID );
$stripe_service->sync_product_and_price_in_stripe( $membership );
try {
$stripe_service->sync_product_and_price_in_stripe( $membership );
} catch ( \Exception $e ) {
wp_delete_post( $new_membership_ID, true );
wp_send_json_error( array( 'message' => $e->getMessage() ) );
}
}

// Create or update content access rule if rule data provided
Expand Down Expand Up @@ -230,6 +235,26 @@ public static function update_membership() {

$data = apply_filters( 'ur_membership_after_create_membership_data_prepare', $data );

if ( $is_stripe_enabled ) {
$meta_data_check = json_decode( $data['post_meta_data']['ur_membership']['meta_value'], true );
if (
'free' !== $meta_data_check['type'] &&
isset( $meta_data_check['subscription']['duration'], $meta_data_check['subscription']['value'] ) &&
'year' === $meta_data_check['subscription']['duration'] &&
(int) $meta_data_check['subscription']['value'] > 3
) {
wp_send_json_error(
array(
'message' => sprintf(
/* translators: %d: number of years */
__( 'Stripe does not support yearly subscription periods greater than 3 years. The value %d years is not allowed. Please set the subscription period to 3 years or less.', 'user-registration' ),
(int) $meta_data_check['subscription']['value']
),
)
);
}
}

$updated_ID = wp_insert_post( $data['post_data'] );

if ( $updated_ID ) {
Expand Down
9 changes: 9 additions & 0 deletions modules/membership/includes/Admin/Services/Stripe/StripeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2890,6 +2890,15 @@ private function create_price_in_stripe(
);

if ( 'subscription' === $type ) {
if ( 'year' === $interval && $interval_count > 3 ) {
throw new \Exception(
sprintf(
/* translators: %d: interval count */
__( 'Stripe does not support yearly subscription periods greater than 3 years. The value %d years is not allowed. Please set the subscription period to 3 years or less.', 'user-registration' ),
$interval_count
)
);
}
$data['recurring'] = array(
'interval' => $interval,
'interval_count' => $interval_count,
Expand Down
Loading