UR-4413 Fix - Admins cannot access content restricted by membership rules#1285
Open
saurab018 wants to merge 1 commit into
Open
UR-4413 Fix - Admins cannot access content restricted by membership rules#1285saurab018 wants to merge 1 commit into
saurab018 wants to merge 1 commit into
Conversation
71025ea to
de1b4be
Compare
de1b4be to
fb94036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
https://themegrill.atlassian.net/browse/UR-4413
The
urm_check_user_membership_has_access()function inmodules/functions-ur-modules.phpwas missing theis_super_admin()early-return that the pro version already has. As a result, when content is restricted via a membership rule, administrators were evaluated against the membership subscription check and blocked if they had no active membership — even though admins should always bypass restrictions.Fix: Added
if ( is_super_admin() ) { return true; }at the top ofurm_check_user_membership_has_access(), matching the pro version exactly.How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry